Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: disable compiler warning when compiling cares using GN #51756

Closed
wants to merge 1 commit into from
Closed

build: disable compiler warning when compiling cares using GN #51756

wants to merge 1 commit into from

Conversation

victorgomes
Copy link

When compiling Node with V8 CI using GN, we get an error due to unused value in cares.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net
  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Feb 14, 2024
@victorgomes victorgomes changed the title gn: cares: disable compiler warning deps: disable compiler warning when compiling cares using GN Feb 14, 2024
juanarbol
juanarbol reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Could you please change the scope to build instead of deps? change the commit title extension so CI is happy?

@victorgomes victorgomes changed the title deps: disable compiler warning when compiling cares using GN build: disable compiler warning when compiling cares using GN Feb 14, 2024
@juanarbol
Copy link
Member

See commit guidelines https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#commit-message-guidelines

@merceyz
Copy link
Member

merceyz commented Feb 14, 2024 •
edited
Loading

This is fixed in #51687.

@victorgomes
Copy link
Author

This is fixed in #51687.

Thanks! I've missed that... I'll close this PR then.

@victorgomes victorgomes mentioned this pull request Feb 14, 2024
Closed
@victorgomes victorgomes deleted the fix-warning branch February 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol left review comments

Assignees
No one assigned
Labels
cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@victorgomes @nodejs-github-bot @juanarbol @merceyz